Many places in the app refer to user.sites to list sites
GET /user retrieved all sites then filtered by site ID, this wasn't sorted
Attn:
In order to properly define test cases in isolation I needed to close and open the db between test cases which adds >10s to this test suite. This is because of some strange behaviour from Massive when attempting to clear the employer_sites table.
When switching to use saveSites I noticed a difference in the validation schemas for the various site editing/creation endpoints which led me to create batchSiteObject. I think this isn't great and I'd love feedback on fixing this. Should we make large scale changes to validation/controllers/client to address these inconsistencies?
Changes:
I consolidated the two getSites methods and handled the access for different roles in that function
Limit fields on getSites to all that's currently needed on FE
Notes:
user.sites
to list sitesGET /user
retrieved all sites then filtered by site ID, this wasn't sortedAttn:
saveSites
I noticed a difference in the validation schemas for the various site editing/creation endpoints which led me to createbatchSiteObject
. I think this isn't great and I'd love feedback on fixing this. Should we make large scale changes to validation/controllers/client to address these inconsistencies?Changes: