bcgov / hcap

Application supporting access to the Health Career Access Program (HCAP) for employers and participants.
Apache License 2.0
2 stars 1 forks source link

HCAP-1341 Remove additional unneeded sorting #845

Closed arranfw closed 2 years ago

arranfw commented 2 years ago

https://freshworks.atlassian.net/browse/HCAP-1341

I guess lodash and postgres treat spaces differently in their sorting algorithms

arranfw commented 2 years ago

@alva-fresh

We also use it in SelectProspectingSiteForm.js and src/pages/private/UserView.js. Do you think it's a good idea to remove it in there as well?

Great call! thank you!

taraepp commented 2 years ago

I think this will deal with some of the sorting behaviour, but postgres's sort is also case-sensitive so I'm thinking there may still be some issues. In the raw query you can do lower()/upper() on the order by field but not sure if massive will cooperate. image

arranfw commented 2 years ago

I think this will deal with some of the sorting behaviour, but postgres's sort is also case-sensitive so I'm thinking there may still be some issues. In the raw query you can do lower()/upper() on the order by field but not sure if massive will cooperate. !

It should at least get the sorting to be consistent between the two components which was my understanding of what this ticket was describing

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication