bcgov / hcap

Application supporting access to the Health Career Access Program (HCAP) for employers and participants.
Apache License 2.0
2 stars 1 forks source link

HCAP-1354 remove Post-hire MOH withdrawal #850

Closed arranfw closed 1 year ago

arranfw commented 2 years ago

https://freshworks.atlassian.net/browse/HCAP-1354

taraepp commented 2 years ago

I thought I saw a couple of potential issues so I pulled and ran it locally to make sure:

arranfw commented 2 years ago

I thought I saw a couple of potential issues so I pulled and ran it locally to make sure:

  • I was unable to archive a hired participant (server says: "error: withdrawParticipant is not a function")
  • I got some warnings during build that I didn't like the look of: image

What is this caused by? What was the issue you saw?

taraepp commented 2 years ago

I thought I saw a couple of potential issues so I pulled and ran it locally to make sure:

  • I was unable to archive a hired participant (server says: "error: withdrawParticipant is not a function")
  • I got some warnings during build that I didn't like the look of: image

What is this caused by? What was the issue you saw?

The warnings were present just when I build (make local-run). I switched to master and confirmed I can build master without the warnings.

I double checked the error just now with a fresh participant and I still got it:

arranfw commented 2 years ago

I've decided to drop the server side check for this feature

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication