bcgov / hcap

Application supporting access to the Health Career Access Program (HCAP) for employers and participants.
Apache License 2.0
2 stars 1 forks source link

HCAP-1279 - MoH: View global phases #870

Closed rhattie-ey closed 1 year ago

rhattie-ey commented 1 year ago

This PR adds a new "Phases List" page, as per HCAP-1279. This page allows MoH users to view all phases globally, and edit their names and dates.

Warning: This branch is dependent on #864! This PR should not be merged until that one is.

In addition, this new page is built on a new, general-purpose DataTable component. This component builds a table from a data source (any async function that returns an array of objects), and a configuration object defining column names, types, and behaviour (in the case of buttons).

Other changes:

rhattie-ey commented 1 year ago

While that duplication flagged by Sonar is somewhat intended, since the plan was to deduplicate at a later date, it does make me wonder how quickly I could get that done now.

It was simple enough to deduplicate the flagged lines. I think it's good this got taken care of right away, too.

vanics commented 1 year ago

Solid work! I just left one minor comment, it looks a sound implementation. Some nitpicks from Noel that I agree with but minor stuff. Thank you.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication