HCAP-1419 - Sites table showing incorrect number of records/duplicate records

[mmumby]

Bug fix

Issue 1:

• The current query for getSitesWithCriteria assumes there is only 1 currentPhase, however, the data does not reflect that. The query was returning 1 record for every phase/allocation associated to the site (ie 9 phases with assigned allocations returned 9 of the same site record to the view sites table)

  Issue 2:

• Phases have an FK to allocations, allocations FK to sites - the current query assumes there is only 1 currentPhase, so only 8 of the 9 records returned has valid dates. The others were displayed as "Invalid Date - Invalid date"

Solution

NOTE: this also only works under the assumption there is 1 current phase and users are not creating dirty data (will be better once validation is built to enforce no overlap in phases)

• Get current phase based on current_date
• Use the phase.id and site.id to match the correct allocation, and return phase start/end date in the response.
• Updated the UI to only display N/A when the allocation is null, since the phase is global not site specific.
• Added documentation to the raw query

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication