search

bcgov / hcap

Application supporting access to the Health Career Access Program (HCAP) for employers and participants.
Apache License 2.0
2 stars 1 forks source link

HCAP-1400: Add types to exports of core server sections #890

Closed rhattie-ey closed 1 year ago

rhattie-ey commented 1 year ago

HCAP-1400, part of HCAP-1399 and overall TypeScript migration

This PR converts top level code and the contents of constants, db, and middleware on the server to TS, and adds typing to some of these files. This improves type safety, and proactively reduces chances of future complex merge conflicts.

Note: this PR also removes the lines-between-class-members ESLint rule - it helps make things more readable with large TS classes, in my opinion, but I am open to discussion on the matter.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication