Closed rhattie-ey closed 1 year ago
I love your attention to details and your dilligence improving the code base. Well done! It looks great. The change was considerable, I skimmed here but will open locally to explore more but so far what I've seem is really god.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
8 Code Smells
No Coverage information
0.9% Duplication
This PR:
participants-helper
participants
reporting
participant-status
setParticipantStatus
was further refactored into multiple smaller functions for readabilityThis PR does not:
services
. It's a huge directory, and certain parts of it are very time consuming to untangle. Some parts will just need to go un-annotated for now. Everyone is encouraged to continue tightening up types when possible.services
. Again, huge directory, and that's out of scope for this ticket. This PR does work in a few refactors, though.