bcgov / hcap

Application supporting access to the Health Career Access Program (HCAP) for employers and participants.
Apache License 2.0
2 stars 1 forks source link

HCAP-1294 - Phase date range validation #897

Closed mmumby closed 1 year ago

mmumby commented 1 year ago

Work completed

New phase form: Screen Shot 2023-02-27 at 5 15 27 PM

Edit phase form: Screen Shot 2023-02-27 at 5 28 59 PM

UI if phase name is very long: Screen Shot 2023-02-28 at 10 01 35 AM

UI if there are multiple long names that overlap - note the user has to intentionally force a large overlap in order to see more than 1 phase in the list. (I added a max height of 250px to the section and a scroll, the scrollbar is only visible when actively scrolling) Screen Shot 2023-02-28 at 12 56 35 PM

https://user-images.githubusercontent.com/25125247/221968762-8a52a018-611b-4e1d-ac66-aa75e5d0119d.mov

UI OPTIONS: (When phase names are long, the dates seem to get lost amongst the words, I've added some bold to see if that's preferrable) Screen Shot 2023-02-28 at 1 49 53 PM Screen Shot 2023-02-28 at 1 51 10 PM This is the current look Screen Shot 2023-02-28 at 1 51 55 PM

rhattie-ey commented 1 year ago

We should merge this after #895 to make resolution simpler.

mmumby commented 1 year ago

@rhattie-ey I'm good with that plan!

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
14.1% 14.1% Duplication