bcgov / hcap

Application supporting access to the Health Career Access Program (HCAP) for employers and participants.

Apache License 2.0

2 stars 1 forks source link

HCAP-1297/1282/1283 - testing followup #909

Closed mmumby closed 1 year ago

mmumby commented 1 year ago

Work completed

Tests for route /allocations/bulk-allocation
tests for new services createBulkAllocation and getAllocationsForSites
Updated tests for getAllPhases with new queryParam includeAllocations
Cypress tests for bulk allocations

Bug fix

During testing of createBulkAllocation, I noticed that the response was being returned before the updates were resolved. Updated the logic to wait for all updates to complete before returning the response.
Updated SonarCloud code smells from the previous PR

Extra

added a flag to the jest server tests to include colour formatting - This isn't necessary, Its a nice visual, will remove if vetoed

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
10.6% Duplication