bcgov / hcap

Application supporting access to the Health Career Access Program (HCAP) for employers and participants.

Apache License 2.0

2 stars 1 forks source link

HCAP-1461 - Site name too long #914

Closed mmumby closed 1 year ago

mmumby commented 1 year ago

work completed

Added max 255 characters for siteName on all yup validations
Added tests to check failure if siteName is too long.
Used addEllipsisMask on the link and modal header for siteName if over 50 characters (For the link - the full site name is displayed directly under, for the modal header if the siteName was too long the modal wouldn't scroll thus preventing editing. The full name is still visible in the form)

clean up

Deleted the truncateString function as a function already existed that did the same thing. addEllipsisMask

rhattie-ey commented 1 year ago

addEllipsisMask could use a better name, but that's OOS for this PR.

rhattie-ey commented 1 year ago

Just noticed the dupe import in SiteViewDetails.js flagged by Sonar, once that's fixed consider this approved by me.

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
17.4% Duplication