bcgov / internationally-educated-nurses

Internationally Educated Nurses
Apache License 2.0
2 stars 1 forks source link

IEN-893 | Subtasks IEN-906, 907 | Upgrade Node to 18 | Upgrade Next to 14 | fix related broken changes #632

Closed jerry-ey closed 1 month ago

jerry-ey commented 1 month ago
jerry-ey commented 1 month ago

going to fix the PR testing fail Fixed the Unit testing fail

jerry-ey commented 1 month ago

going to fix e2e fail

   Spec                                              Tests  Passing  Failing  Pending  Skipped  

┌────────────────────────────────────────────────────────────────────────────────────────────────┐ │ ✔ 1-login/login.spec.ts 00:04 2 2 - - - │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ 2-applicants/filter-applicants.spec 00:04 1 1 - - - │ │ .ts │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ 2-applicants/search.spec.ts 00:04 1 1 - - - │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✖ 3-details/job.spec.ts 02:08 11 8 3 - - │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ 3-details/milestones.spec.ts 00:11 4 4 - - - │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ 4-reports/data-extract.spec.ts 00:06 2 2 - - - │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ 4-reports/report.spec.ts 00:03 2 2 - - - │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ 5-user-management/applicant-read-ac 00:03 1 1 - - - │ │ cess.spec.ts │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ 5-user-management/change-role.spec. 00:05 4 4 - - - │ │ ts │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ 5-user-management/search-users.spec 00:07 2 2 - - - │ │ .ts │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ 5-user-management/user-pagination.s 00:03 1 1 - - - │ │ pec.ts │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✖ 6-ha/assign-to-me.spec.ts 02:14 7 3 4 - - │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ 6-ha/ha-user.spec.ts 00:08 4 3 - 1 - │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ 6-ha/inactive-active-applicants.spe 00:07 4 4 - - - │ │ c.ts │ ├────────────────────────────────────────────────────────────────────────────────────────────────┤ │ ✔ 7-admin/bccnm-ncas-update.spec.ts 00:04 4 4 - - - │ └────────────────────────────────────────────────────────────────────────────────────────────────┘ ✖ 2 of 15 failed (13%) 05:38 50 42 7 1 -

Error: Command failed with exit code 1: yarn test:seed && yarn start:cypress at makeError (/home/runner/work/internationally-educated-nurses/internationally-educated-nurses/node_modules/start-server-and-test/node_modules/execa/lib/error.js:60:11) at handlePromise (/home/runner/work/internationally-educated-nurses/internationally-educated-nurses/node_modules/start-server-and-test/node_modules/execa/index.js:118:26) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) { shortMessage: 'Command failed with exit code 1: yarn test:seed && yarn start:cypress', command: 'yarn test:seed && yarn start:cypress', escapedCommand: '"yarn test:seed && yarn start:cypress"', exitCode: 1, signal: undefined, signalDescription: undefined, stdout: undefined, stderr: undefined, failed: true, timedOut: false, isCanceled: false, killed: false } make: *** [Makefile:232: test-e2e] Error 1 Error: Process completed with exit code 2.

jerry-ey commented 1 month ago

Found styling issue after deploying to TEST but not happen on my local. Have to do more research. style issue is fixed.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud