CrystalChadburn
commented
2 years ago @hpertaia Mike Wells and i chatted about the PMP issues and came to the final decision reflected in the ticket above. I've also add a number of other small fixes required please.
ISSUE: Currently the PMP field only allows users to choose from a drop down (with 4 PMPs), however other users will need to be able to enter their own PMP number that is not on the list.
[x] Create a new field called "unlisted drop down" right after the "Pest Management Plan" field that is a user entered field with text and numbers and symbols. This new field and the existing PMP drop down field need to both export into one column called 'Pest Management Plan' so that when we export we see what people put in either. Validation - users will enter either the drop down OR enter the new "unlisted drop down" field, so make both optional.
[x] remove the chemical treatment method field from under the chemical treatment information section/object (it is already down below).
[x] add the following help text for the wells object "These fields are autofilled if InvasivesBC detects a mapped well within the vicinity of a treatment. If nothing is entered, there are no mapped wells found however this does NOT mean there are no wells present. It is the applicators responsibility to confirm the absence of wells prior to applying herbicide at all times."
[x] add help text to "well ID" field: "Autofilled field when InvasivesBC detects a mapped well within the location of the treatment area. If nothing is entered, there are no mapped wells found however this does NOT mean there are no wells present. It is the applicators responsibility to confirm the absence of wells prior to applying herbicide at all times."
[x] add help text to "well proximity" field: "Autofilled field when InvasivesBC detects a mapped well within the location of the treatment area. If nothing is entered, there are no mapped wells found however this does NOT mean there are no wells present. It is the applicators responsibility to confirm the absence of wells prior to applying herbicide at all times."
[x] add text to "Chemical Treatment Details" object at the top where all the validation rules show up before you even enter the data that explains that the validation rules will disappear once data is entered into the fields below OR move the error messages to the bottom of this section if that is possible (@micheal-w-wells is looking into this too)
[x] make the "Humidity" field optional.
[x] this form still has the "old" way of entering names with two fields for chemical applicators. It works fine as is, but if we need to standardize the way names are collected/autofilled, it would be better to put the name field in a new object like the other forms, and have the add item button. BUT in this case each name must also have the applicator licence number associated with it so that may be why it was left as is. Works for the user, just want to make sure it works for the back end please.
[x] BUG: the "your treatment rate exceeds the maximum allowed rate for the chemical product" warning persists even after the user has fixed the application rate. It popped up again when i went back into the form to edit again, despite the numbers in the herbicide section being changed to correct.
[x] all of these fixes have been made on both the aquatic and terrestrial treatment forms.
[x] Check the mandatory field statuses for Pest Management Plan (PMP) and Pesticide Use Permit (PUP) fields. Ideally should be mandatory to fill in the PMP OR the PUP field, PLUS ensure that if any percentage of jurisdiction is private then both PMP and PUP fields become optional. If that is not possible, leave the PMP and PUP fields as both optional. This fix is required in BOTH the terrestrial AND aquatic treatment forms.