bcgov / invasivesbc

Inventory and database repository for the creation, treatment, and report on BC Invasive plants and animals.

Apache License 2.0

13 stars 4 forks source link

[INV-3528] 'Suggested' ActionCreators Converted Over #3561

Closed LocalNewsTV closed 1 month ago

LocalNewsTV commented 1 month ago

Overview

A Portion of the work being done for #3428

This PR includes the following proposed change(s):

Draftstate for Activity is now typed, finding errors
- Stubbed the keys that were flagged as non-existent from this change
Created type for SuggestedTreatmentId
Finished converting Suggestions type actions into Action Creators
Tidied up typing, reducing warnings.

Unused Keys

Following keys were unused, and deleted.

ACTIVITY_GET_SUGGESTED_PERSONS_REQUEST_OFFLINE
ACTIVITY_GET_SUGGESTED_TREATMENT_IDS_REQUEST_OFFLINE

Testing

Created form, Results from Dev / Local matched on Linked treatment Ids
Created form, If you empty the string containing your name, it still repopulates it with your name

sonarcloud[bot] commented 1 month ago

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud