bcgov / invasivesbc

Inventory and database repository for the creation, treatment, and report on BC Invasive plants and animals.

Apache License 2.0

13 stars 4 forks source link

Refactor Map Helpers for readability #3603

Closed plasticviking closed 4 weeks ago

plasticviking commented 1 month ago

Overview

This PR includes the following proposed change(s):

Decompose Helpers.tsx into related code
Change long parameter lists to options objects and begin adding typing
No substantial changes -- just tidying

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Refactoring / Documentation
[ ] Version change

if your change is a breaking change, please add breaking change label to this PR

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Screenshots

Please add any relevant UI screenshots if applicable.

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] New and existing unit tests pass locally with my changes

sonarcloud[bot] commented 1 month ago

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
4.2% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint