bcgov / jag-document-utils

Justice Sector PDF Merge Microservice integration with Adobe Experience Manager

Apache License 2.0

1 stars 1 forks source link

Adding more Tests #36

Closed alexjoybc closed 3 years ago

alexjoybc commented 3 years ago

Description

This PR includes the following proposed change(s):

Add more unit test
Refactor Utils

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactoring / Documentation
[ ] Version change

if your change is a breaking change, please add breaking change label to this PR

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] New and existing unit tests pass locally with my changes

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit 4381acc1 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	2

The test coverage on the diff in this pull request is 96.4% (50% is the threshold).

This pull request will bring the total coverage in the repository to 68.7% (6.2% change).

View more on Code Climate.