Closed Baelx closed 1 year ago
I think this ticket is a great initiative and I'm stoked that it will be going to production. There are a couple of small things here:
* Some colour variables could be given more readable names (that include the colour name) * Some colours still use hex literals instead of variables * There is some commented out code that may be intentional, but I left a comment in case it's not * The colour black is given a variable many times, possibly because this is a retrofit and we want the variables separate in the future. If not, then we should consider consolidating some variables either now or in a future ticket.
Thanks for the thorough review @robrien-bcgov @jareth-whitney.
This work was originally done by Steve Howard in 2022. We're now merging it into the dev branch for testing and deployment to prod.
See: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-270