bcgov / lcfs

An online application for fuel suppliers to manage their compliance obligations under the Low Carbon Fuels Act
Apache License 2.0
5 stars 3 forks source link

LCFS - BUG - Duplicate row validation with End use #1216

Open airinggov opened 1 week ago

airinggov commented 1 week ago

1. Describe the Bug This should not be throwing an error Image

Expected Behaviour The End use should also be part of the duplicate row validation, having a different End use makes this a unique fuel.

Actual Behaviour It doesn't appear End use is part of the duplicate row validation.

Implications This prevents suppliers from reporting fuels accurately.


2. Spike Problem Description After deleting a duplicate row, trying to input the same information, it is as if the error matching hasn't been cleared and a duplicate row error is given when it shouldn't be

Image

In order to Enable suppliers to report fuel data accurately without encountering erroneous duplicate errors, the system needs to validate rows.

Solution Needs

Timebox Allocate up to 3 points to investigate and prototype a validation update for duplicate entries.

Outcome

Additional Context

airinggov commented 3 days ago

@kevin-hashimoto Still getting a duplicate row error on this

Image

airinggov commented 3 days ago

@kevin-hashimoto log in with LCFS10 if you want to try recreate this

kevin-hashimoto commented 9 hours ago

@airinggov thats odd, I deleted the existing rows ( in the ui, not the db table ) and tried again and it seems to be working correctly.

I've added 3 rows with same values except for 'end use', deleted those and then added a row with the same value as the rows that were deleted.

Image Image

Maybe something changed during one of the other PRs, let me know if this is still happening and we can hop on a call and walk through it