Closed justin-lepitzki closed 4 months ago
Hey team! Please add your planning poker estimate with Zenhub @AlexZorkin @hamed-valiollahi @kevin-hashimoto @prv-proton
Found the following issues:
1) The transactions are downloading on the BCeID side, but not on the IDIR side for all organizations (Only works if you filter by organization). We want to be able to download all transactions from all organizations.
2) Compliance period, category and effective date columns are not showing any information in the Excel sheet. We should also include an 'Approval date' column if possible.
Please see screenshot of Excel sheet:
@Grulin , Thanks, Lindsy, for testing and reporting the issues.
Thank you
Hi Hamed,
Thank you for the notes. Your first 4 points make sense. I only just realized that compliance period likely has not bee established yet since the fuel supply reporting sections are not complete. I think this will be added later.
For the final point, I think we should drop the column "Approval Date" and relabel the "Effective date" column to read "Recorded/Approved Date" if possible?
Hi Lindsy,
Thank you for reviewing my comments and providing your feedback.
... we should drop the column "Approval Date" and relabel the "Effective Date" column to "Recorded/Approved Date" if possible?
I'm sorry, I'm not sure if I understand this part correctly. Let me share my understanding so you can correct me if I'm wrong.
We have three types of transactions: Transfer, Admin Adjustment, and Initiative Agreement. Each type has its own "Effective Date", which we store as a date and time.
Also, each transaction type has several statuses, and we create a history record whenever the status changes with a date/time.
Transfer:
Admin Adjustment:
Initiative Agreement:
So, should we drop the "Approval Date" and "Effective Date" columns, and add a "Recorded" column for transfers and an "Approved" column for admin adjustments and initiative agreements?
Thank you
Hi Hamed,
Sorry for the confusion. Yes, your proposal here makes sense. Please drop the "Approval Date" column, but please keep the "Effective Date" column for admin adjustments and initiative agreements. This date can differ from the approved date for the admin adjustments and initiative agreements. It comes from the grey box in the transaction, rather than the status change:
Please add a "Recorded" column for transfers and an "Approved" column for admin adjustments and initiative agreements. Ultimately this is the date we track in our market reports for transfers, so it makes sense to have these displayed in this Excel sheet.
Thank you for the clarification, Lindsy. I appreciate it. I'll apply the requested changes.
Hi @hamed-valiollahi This download looks great. The columns are now correct, but I was hoping we could only show "Approved" and "Recorded" status transactions in the "Status" column. Sorry I didn't make that clear before. It's currently showing all the different statuses (including draft, submitted and recommended). Thank you.
Description:
Note: This feature is near identical to the one that exists in TFRS
Wireframe:
UXPin: https://preview.uxpin.com/59145260c7d8cc48969ac79401cc03d84843c3d9#/pages/165270334/simulate/no-panels
Screenshot of example spreadsheet from TFRS:
"Downloading..." button example from TFRS: Private Zenhub Image
Purpose and benefit to user: Users can easily and efficiently download a list of transactions.
Acceptance Criteria:
Development Checklist:
SpreadsheetBuilder
frombackend/lcfs/utils/spreadsheet_builder.py
for generating the Excel file.frontend/src/views/Organizations/Organizations.jsx
. Specifically, examineDownloadButton
andhandleDownloadOrgs
for guidance on integrating the download functionality.Notes: