bcgov / lcfs

An online application for fuel suppliers to manage their compliance obligations under the Low Carbon Fuels Act
Apache License 2.0
5 stars 3 forks source link

LCFS - Edit a draft transfer #230

Closed justin-lepitzki closed 5 months ago

justin-lepitzki commented 10 months ago

Description: Creating the ability to edit a draft transfer. Once a new transfer is saved as a draft, the user is returned to the main transactions table. If a user then clicks on the draft transfer in the transaction table:

Wireframe: https://preview.uxpin.com/59145260c7d8cc48969ac79401cc03d84843c3d9#/pages/164927056/simulate/no-panels

Purpose and benefit to user: Users can change the details of their draft transfers prior to executing them.

Acceptance Criteria:

Development Checklist:

Notes:

prv-proton commented 10 months ago

Hey team! Please add your planning poker estimate with Zenhub @prv-proton @jig-patel

Grulin commented 6 months ago

The transfer ID number is not visible at the top of the page.

What the current edit transfer page shows:

Image

Example for how the transfer ID # should be showing on the edit transfer page:

Image

1) Transfer ID view page title should be shown as "Transfer ID:#" on the individual transfer page.

2) Edit transfer page title should be shown as "Edit Transfer ID: #"

3) Final breadcrumb ID # for any transactions (IA, transfers, admin adjustment, etc.) should be shown as "ID: #"

Please see example of title and breadcrumb ID:# in screenshot:

Image

Grulin commented 6 months ago

Acceptance criteria not met: Given I am a BCeID user but not on transfer role, then shouldn't be able to edit but still be able to access and view the transfer in read only mode.

As a BCeID user, I am still able to edit and save a transfer without being assigned the 'transfer' role to my user profile.

Grulin commented 6 months ago

As a BCeID user with the 'signing authority' only role, I can correctly only save it or sign and send it. But when I select 'Save draft', the green validation message I receive is incorrect. It should say 'Draft transfer successfully saved'. See screenshot for current incorrect validation message:

Image

As a BCeID user with the 'transfer' only role, I can edit a draft transfer, but when I select 'Save draft', I received a Failed 500 error:

Image

Grulin commented 5 months ago

Still getting an error when I select "save draft". The new input for compliance units field is not persisting after I hit 'save draft'. It continues to revert back to the previously saved input and I get the following error (please see screenshot):

Image

prv-proton commented 5 months ago

Still getting an error when I select "save draft". The new input for compliance units field is not persisting after I hit 'save draft'. It continues to revert back to the previously saved input and I get the following error (please see screenshot):

Image

@Grulin, This was related to issue with user role, it had the government role attached to it. Have removed it from DB now it should work. Please let me know if it is still persisting.