bcgov / lcfs

An online application for fuel suppliers to manage their compliance obligations under the Low Carbon Fuels Act
Apache License 2.0
5 stars 3 forks source link

LCFS - Fuel codes, add Contact name and Contact email #647

Closed airinggov closed 4 months ago

airinggov commented 5 months ago

Description: The business area would like to add optional contact information (name and email) to fuel codes to help notify fuel producers when fuel codes are near expiry.

Wireframe: https://preview.uxpin.com/da68049c0af15edd7ce4e47e4bee431fed40c30d#/pages/168739509?mode=m

Purpose and benefit to user: The business area would like to investigate having LCFS automate 90 alerts for expiring fuel codes. Fuel producers would receive an email to update their fuel codes.

Acceptance Criteria:

Dev Notes

Notes: Fuel producers are not the same as fuel suppliers. They are not users of TFRS/LCFS, they may not operate in BC and may not be eligible to get a Business BCeID.

airinggov commented 4 months ago

@AlexZorkin @kevin-hashimoto receiving a 500 error accessing the fuel code page and the new fuel code button also gives an error so these cards can't be tested

kevin-hashimoto commented 4 months ago

@airinggov I believe this should be fixed on dev now. we had a problem with the seeders

Grulin commented 4 months ago

The 'Contact name', 'Contact email' columns should be optional but they are currently showing as required.

'Former company' is also showing as required and it should be optional instead.

Grulin commented 4 months ago

The column "Former company" is still showing up as a required field. This should not be a required field:

Image

airinggov commented 4 months ago

contact email is still not saving when null

Image