bcgov / lcfs

An online application for fuel suppliers to manage their compliance obligations under the Low Carbon Fuels Act
Apache License 2.0
5 stars 3 forks source link

Refactor FuelCode Component to New agGrid Setup #811

Closed AlexZorkin closed 2 months ago

AlexZorkin commented 2 months ago

Description

Refactor the FuelCode component to use our new agGrid setup, similar to the recently refactored FuelSupply component. This will improve consistency across our application and potentially enhance performance and maintainability.

Purpose and Benefit to User

Acceptance Criteria

  1. The FuelCode component uses the new agGrid setup, matching the structure and patterns used in the FuelSupply component.
  2. All existing functionality is preserved, including:
    • Displaying and editing fuel code data
    • Adding new rows
    • Duplicating rows
    • Deleting rows
    • Validation of data
    • Cloning functionality
  3. The refactored component correctly interacts with the backend API, including saving changes and retrieving data.
  4. The user interface remains consistent with the current design, despite the underlying changes.
  5. Performance is maintained or improved compared to the current implementation.
  6. All existing unit tests pass, and new tests are added or updated as necessary.

Development Checklist

Additional Notes

airinggov commented 2 months ago

The Feedstock/Location and Fuel Production City/Province/Country fields don't save new values, only existing (predictive) values can be saved.

AlexZorkin commented 2 months ago

Fixed the autocomplete component to work with custom inputs for our new ag-grid implementation.

airinggov commented 2 months ago

Feedstock/Location now will save new info but Fuel Production City/Province/Country still don't