bcgov / lcrb-dav

LCRB Digital Age Verification Service
Apache License 2.0
0 stars 6 forks source link

QR code not masking when scanned, decline not handled #39

Closed loneil closed 1 month ago

loneil commented 1 month ago

Seeing these issues in https://dav.bcpavco.com/dav/ and running main locally

QR Code does not mask/obscure when pending proof

image

as well, when declining a proof request nothing happens. QR Code remains on screen without feedback.

In both these cases the wallet user can re-scan and the QR code proof is not valid any more, presenting an "Invalid QR code" error in the wallet.

Need to prevent QR re-scans.

loneil commented 1 month ago

https://github.com/bcgov/lcrb-dav/pull/38 fixes this