bcgov / ligo-lib

A Python library to support the Ligo linking application.
https://github.com/bcgov/ligo
Apache License 2.0
1 stars 1 forks source link

File Existence Check #4

Open NovaVic opened 7 years ago

NovaVic commented 7 years ago

What if we are trying to close a file that could not be created for writing?

Initially I was confused regarding the purpose of statements like the above. After talking to Khalegh I understood that he is trying to make sure that the file that he will need soon exists.

Another similar one : https://github.com/bcgov-c/data-linking/blob/develop-2.0/lib/cdi-linking/cdilinker/linker/chunked_dedup.py#L261

There are couple of similar ones in https://github.com/bcgov-c/data-linking/blob/develop-2.0/lib/cdi-linking/cdilinker/linker/chunked_link.py as well.

Khalegh-H3 commented 7 years ago

File existence check has been added whenever it applies. File checking is done as part of commit https://github.com/bcgov-c/data-linking/commit/9c878eaf9aa804b325ec7367a9eb863c71335ee8.