bcgov / met-public

Modern Engagement Tool ops
Apache License 2.0
6 stars 19 forks source link

Bugfix/deseng575 Language picker should only appear on engagements with more than one language #2496

Closed Baelx closed 4 months ago

Baelx commented 4 months ago

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-575

Description of changes:

I've had to kneecap the language switcher functionality until we can make some design decisions regarding what to do about:

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 85.18519% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 75.76%. Comparing base (2ca9a8d) to head (2fe48f3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2496 +/- ## ========================================== + Coverage 75.70% 75.76% +0.06% ========================================== Files 590 589 -1 Lines 21107 21114 +7 Branches 1530 1528 -2 ========================================== + Hits 15978 15997 +19 + Misses 4882 4870 -12 Partials 247 247 ``` | [Flag](https://app.codecov.io/gh/bcgov/met-public/pull/2496/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [metapi](https://app.codecov.io/gh/bcgov/met-public/pull/2496/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `87.89% <100.00%> (+0.02%)` | :arrow_up: | | [metweb](https://app.codecov.io/gh/bcgov/met-public/pull/2496/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `63.52% <74.19%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/bcgov/met-public/pull/2496?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [...t-api/src/met\_api/models/engagement\_translation.py](https://app.codecov.io/gh/bcgov/met-public/pull/2496?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fmodels%2Fengagement_translation.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9tb2RlbHMvZW5nYWdlbWVudF90cmFuc2xhdGlvbi5weQ==) | `96.82% <100.00%> (+0.33%)` | :arrow_up: | | [...pi/src/met\_api/resources/engagement\_translation.py](https://app.codecov.io/gh/bcgov/met-public/pull/2496?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fresources%2Fengagement_translation.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9yZXNvdXJjZXMvZW5nYWdlbWVudF90cmFuc2xhdGlvbi5weQ==) | `98.91% <100.00%> (+0.14%)` | :arrow_up: | | [...met\_api/services/engagement\_translation\_service.py](https://app.codecov.io/gh/bcgov/met-public/pull/2496?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fservices%2Fengagement_translation_service.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9zZXJ2aWNlcy9lbmdhZ2VtZW50X3RyYW5zbGF0aW9uX3NlcnZpY2UucHk=) | `88.65% <100.00%> (+0.74%)` | :arrow_up: | | [met-web/src/apiManager/endpoints/index.ts](https://app.codecov.io/gh/bcgov/met-public/pull/2496?src=pr&el=tree&filepath=met-web%2Fsrc%2FapiManager%2Fendpoints%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvYXBpTWFuYWdlci9lbmRwb2ludHMvaW5kZXgudHM=) | `100.00% <ø> (ø)` | | | [.../src/components/engagement/view/EngagementView.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2496?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fview%2FEngagementView.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L3ZpZXcvRW5nYWdlbWVudFZpZXcudHN4) | `81.13% <93.33%> (+4.20%)` | :arrow_up: | | [met-web/src/components/common/LanguageContext.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2496?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fcommon%2FLanguageContext.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9jb21tb24vTGFuZ3VhZ2VDb250ZXh0LnRzeA==) | `62.50% <62.50%> (ø)` | | | [met-web/src/services/engagementService/index.ts](https://app.codecov.io/gh/bcgov/met-public/pull/2496?src=pr&el=tree&filepath=met-web%2Fsrc%2Fservices%2FengagementService%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvc2VydmljZXMvZW5nYWdlbWVudFNlcnZpY2UvaW5kZXgudHM=) | `31.81% <50.00%> (+4.04%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/bcgov/met-public/pull/2496/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov)
Baelx commented 4 months ago

LGTM!

Thanks @ratheesh-aot . I'm just finishing fixing the linter/test errors and will merge in a second

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud