search

bcgov / met-public

Modern Engagement Tool ops
Apache License 2.0
6 stars 19 forks source link

[To Main] Add tenant listing page #2503

Closed NatSquared closed 4 months ago

NatSquared commented 4 months ago

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-592

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 80.89888% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 75.81%. Comparing base (bb62952) to head (a8df1a1). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2503 +/- ## ========================================== + Coverage 75.78% 75.81% +0.03% ========================================== Files 590 597 +7 Lines 21133 21363 +230 Branches 1529 1568 +39 ========================================== + Hits 16016 16197 +181 - Misses 4870 4912 +42 - Partials 247 254 +7 ``` | [Flag](https://app.codecov.io/gh/bcgov/met-public/pull/2503/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [metapi](https://app.codecov.io/gh/bcgov/met-public/pull/2503/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `87.93% <63.15%> (+0.04%)` | :arrow_up: | | [metweb](https://app.codecov.io/gh/bcgov/met-public/pull/2503/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `63.82% <83.01%> (+0.23%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/bcgov/met-public/pull/2503?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [met-web/src/apiManager/endpoints/index.ts](https://app.codecov.io/gh/bcgov/met-public/pull/2503?src=pr&el=tree&filepath=met-web%2Fsrc%2FapiManager%2Fendpoints%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvYXBpTWFuYWdlci9lbmRwb2ludHMvaW5kZXgudHM=) | `100.00% <ø> (ø)` | | | [met-web/src/components/FormCAC/FirstTab.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2503?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2FFormCAC%2FFirstTab.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9Gb3JtQ0FDL0ZpcnN0VGFiLnRzeA==) | `88.46% <100.00%> (ø)` | | | [met-web/src/components/FormCAC/Form.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2503?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2FFormCAC%2FForm.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9Gb3JtQ0FDL0Zvcm0udHN4) | `100.00% <100.00%> (ø)` | | | [met-web/src/components/FormCAC/SecondTab.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2503?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2FFormCAC%2FSecondTab.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9Gb3JtQ0FDL1NlY29uZFRhYi50c3g=) | `81.81% <100.00%> (ø)` | | | [...omments/admin/review/emailPreview/EmailPreview.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2503?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fcomments%2Fadmin%2Freview%2FemailPreview%2FEmailPreview.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9jb21tZW50cy9hZG1pbi9yZXZpZXcvZW1haWxQcmV2aWV3L0VtYWlsUHJldmlldy50c3g=) | `82.60% <100.00%> (ø)` | | | [...ments/admin/review/emailPreview/EmailTemplates.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2503?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fcomments%2Fadmin%2Freview%2FemailPreview%2FEmailTemplates.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9jb21tZW50cy9hZG1pbi9yZXZpZXcvZW1haWxQcmV2aWV3L0VtYWlsVGVtcGxhdGVzLnRzeA==) | `100.00% <100.00%> (ø)` | | | [...ts/comments/admin/reviewListing/AdvancedSearch.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2503?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fcomments%2Fadmin%2FreviewListing%2FAdvancedSearch.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9jb21tZW50cy9hZG1pbi9yZXZpZXdMaXN0aW5nL0FkdmFuY2VkU2VhcmNoLnRzeA==) | `63.15% <100.00%> (ø)` | | | [...nents/comments/admin/reviewListing/Submissions.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2503?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fcomments%2Fadmin%2FreviewListing%2FSubmissions.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9jb21tZW50cy9hZG1pbi9yZXZpZXdMaXN0aW5nL1N1Ym1pc3Npb25zLnRzeA==) | `81.81% <100.00%> (ø)` | | | [...rc/components/comments/admin/textListing/index.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2503?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fcomments%2Fadmin%2FtextListing%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9jb21tZW50cy9hZG1pbi90ZXh0TGlzdGluZy9pbmRleC50c3g=) | `80.00% <100.00%> (ø)` | | | [met-web/src/components/common/index.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2503?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fcommon%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9jb21tb24vaW5kZXgudHN4) | `94.25% <100.00%> (+2.68%)` | :arrow_up: | | ... and [102 more](https://app.codecov.io/gh/bcgov/met-public/pull/2503?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | | ... and [17 files with indirect coverage changes](https://app.codecov.io/gh/bcgov/met-public/pull/2503/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov)
sonarcloud[bot] commented 4 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint