bcgov / met-public

Modern Engagement Tool ops
Apache License 2.0
6 stars 19 forks source link

[To Main] DESENG-579: Add language to survey email links #2507

Closed NatSquared closed 3 months ago

NatSquared commented 3 months ago

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-579

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 80.55556% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 75.82%. Comparing base (1b990ba) to head (12f0caf). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2507 +/- ## ========================================== + Coverage 75.78% 75.82% +0.04% ========================================== Files 597 597 Lines 21334 21342 +8 Branches 1568 1568 ========================================== + Hits 16167 16182 +15 + Misses 4913 4906 -7 Partials 254 254 ``` | [Flag](https://app.codecov.io/gh/bcgov/met-public/pull/2507/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [metapi](https://app.codecov.io/gh/bcgov/met-public/pull/2507/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `87.97% <80.00%> (+0.08%)` | :arrow_up: | | [metweb](https://app.codecov.io/gh/bcgov/met-public/pull/2507/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `63.81% <83.33%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/bcgov/met-public/pull/2507?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [met-api/src/met\_api/config.py](https://app.codecov.io/gh/bcgov/met-public/pull/2507?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fconfig.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9jb25maWcucHk=) | `97.36% <100.00%> (+0.03%)` | :arrow_up: | | [met-api/src/met\_api/schemas/email\_verification.py](https://app.codecov.io/gh/bcgov/met-public/pull/2507?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fschemas%2Femail_verification.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9zY2hlbWFzL2VtYWlsX3ZlcmlmaWNhdGlvbi5weQ==) | `100.00% <100.00%> (ø)` | | | [...src/met\_api/services/email\_verification\_service.py](https://app.codecov.io/gh/bcgov/met-public/pull/2507?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fservices%2Femail_verification_service.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9zZXJ2aWNlcy9lbWFpbF92ZXJpZmljYXRpb25fc2VydmljZS5weQ==) | `92.02% <100.00%> (ø)` | | | [...components/comments/admin/review/CommentReview.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2507?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fcomments%2Fadmin%2Freview%2FCommentReview.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9jb21tZW50cy9hZG1pbi9yZXZpZXcvQ29tbWVudFJldmlldy50c3g=) | `69.73% <100.00%> (+0.20%)` | :arrow_up: | | [...-web/src/components/engagement/view/EmailModal.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2507?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fview%2FEmailModal.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L3ZpZXcvRW1haWxNb2RhbC50c3g=) | `55.10% <100.00%> (+0.93%)` | :arrow_up: | | [...web/src/services/emailVerificationService/index.ts](https://app.codecov.io/gh/bcgov/met-public/pull/2507?src=pr&el=tree&filepath=met-web%2Fsrc%2Fservices%2FemailVerificationService%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvc2VydmljZXMvZW1haWxWZXJpZmljYXRpb25TZXJ2aWNlL2luZGV4LnRz) | `22.58% <ø> (ø)` | | | [met-web/src/services/submissionService/index.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2507?src=pr&el=tree&filepath=met-web%2Fsrc%2Fservices%2FsubmissionService%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvc2VydmljZXMvc3VibWlzc2lvblNlcnZpY2UvaW5kZXgudHN4) | `19.56% <ø> (ø)` | | | [met-api/src/met\_api/services/submission\_service.py](https://app.codecov.io/gh/bcgov/met-public/pull/2507?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fservices%2Fsubmission_service.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9zZXJ2aWNlcy9zdWJtaXNzaW9uX3NlcnZpY2UucHk=) | `78.22% <90.00%> (+0.24%)` | :arrow_up: | | [...gagement/view/widgets/Subscribe/EmailListModal.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2507?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fview%2Fwidgets%2FSubscribe%2FEmailListModal.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L3ZpZXcvd2lkZ2V0cy9TdWJzY3JpYmUvRW1haWxMaXN0TW9kYWwudHN4) | `43.75% <50.00%> (-1.42%)` | :arrow_down: | | [met-api/src/met\_api/services/engagement\_service.py](https://app.codecov.io/gh/bcgov/met-public/pull/2507?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fservices%2Fengagement_service.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9zZXJ2aWNlcy9lbmdhZ2VtZW50X3NlcnZpY2UucHk=) | `71.35% <28.57%> (-0.35%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/bcgov/met-public/pull/2507/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov)
sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud