bcgov / met-public

Modern Engagement Tool ops
Apache License 2.0
6 stars 19 forks source link

DESENG-611: Splitting translations based on language and common #2525

Closed ratheesh-aot closed 2 months ago

ratheesh-aot commented 2 months ago

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-611

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

ratheesh-aot commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Its because of the TODO Statements to replace tenant specific values from database which will done in another story

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 76.02%. Comparing base (0959d82) to head (b8e1b55).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2525 +/- ## ========================================== - Coverage 76.04% 76.02% -0.03% ========================================== Files 617 617 Lines 22093 22095 +2 Branches 1686 1688 +2 ========================================== - Hits 16801 16798 -3 - Misses 5028 5032 +4 - Partials 264 265 +1 ``` | [Flag](https://app.codecov.io/gh/bcgov/met-public/pull/2525/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [metweb](https://app.codecov.io/gh/bcgov/met-public/pull/2525/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `64.70% <58.33%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/bcgov/met-public/pull/2525?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [...components/comments/admin/review/CommentReview.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2525?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fcomments%2Fadmin%2Freview%2FCommentReview.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9jb21tZW50cy9hZG1pbi9yZXZpZXcvQ29tbWVudFJldmlldy50c3g=) | `69.93% <100.00%> (ø)` | | | [...et-web/src/components/landing/LandingComponent.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2525?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Flanding%2FLandingComponent.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9sYW5kaW5nL0xhbmRpbmdDb21wb25lbnQudHN4) | `100.00% <ø> (ø)` | | | [...eb/src/components/layout/Header/InternalHeader.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2525?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Flayout%2FHeader%2FInternalHeader.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9sYXlvdXQvSGVhZGVyL0ludGVybmFsSGVhZGVyLnRzeA==) | `67.44% <100.00%> (-1.45%)` | :arrow_down: | | [met-web/src/hooks.ts](https://app.codecov.io/gh/bcgov/met-public/pull/2525?src=pr&el=tree&filepath=met-web%2Fsrc%2Fhooks.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvaG9va3MudHM=) | `48.38% <50.00%> (-7.62%)` | :arrow_down: |
sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint