bcgov / met-public

Modern Engagement Tool ops
Apache License 2.0
6 stars 19 forks source link

DESENG-612: Replaced tenant specific variables with data from backend #2528

Closed ratheesh-aot closed 2 months ago

ratheesh-aot commented 2 months ago

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-612

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 75.99%. Comparing base (ada21a5) to head (25477fd). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2528 +/- ## ========================================== + Coverage 75.93% 75.99% +0.06% ========================================== Files 616 619 +3 Lines 22007 22096 +89 Branches 1688 1702 +14 ========================================== + Hits 16710 16792 +82 - Misses 5032 5039 +7 Partials 265 265 ``` | [Flag](https://app.codecov.io/gh/bcgov/met-public/pull/2528/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [metweb](https://app.codecov.io/gh/bcgov/met-public/pull/2528/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `64.91% <53.33%> (+0.21%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/bcgov/met-public/pull/2528?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [...components/comments/admin/review/CommentReview.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2528?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fcomments%2Fadmin%2Freview%2FCommentReview.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9jb21tZW50cy9hZG1pbi9yZXZpZXcvQ29tbWVudFJldmlldy50c3g=) | `70.32% <100.00%> (+0.38%)` | :arrow_up: | | [...et-web/src/components/landing/LandingComponent.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2528?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Flanding%2FLandingComponent.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9sYW5kaW5nL0xhbmRpbmdDb21wb25lbnQudHN4) | `100.00% <100.00%> (ø)` | | | [...eb/src/components/layout/Header/InternalHeader.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2528?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Flayout%2FHeader%2FInternalHeader.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9sYXlvdXQvSGVhZGVyL0ludGVybmFsSGVhZGVyLnRzeA==) | `68.88% <100.00%> (+1.44%)` | :arrow_up: | | [met-web/src/reduxSlices/tenantSlice.ts](https://app.codecov.io/gh/bcgov/met-public/pull/2528?src=pr&el=tree&filepath=met-web%2Fsrc%2FreduxSlices%2FtenantSlice.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvcmVkdXhTbGljZXMvdGVuYW50U2xpY2UudHM=) | `25.00% <0.00%> (-13.47%)` | :arrow_down: | ... and [26 files with indirect coverage changes](https://app.codecov.io/gh/bcgov/met-public/pull/2528/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov)
sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud