bcgov / met-public

Modern Engagement Tool ops
Apache License 2.0
6 stars 19 forks source link

[To Main] Fix for issue of null appearing in public URLs #2529

Closed VineetBala-AOT closed 2 months ago

VineetBala-AOT commented 2 months ago

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-625

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 75.99%. Comparing base (2b853c6) to head (20a371a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2529 +/- ## ======================================= Coverage 75.99% 75.99% ======================================= Files 619 619 Lines 22096 22094 -2 Branches 1702 1702 ======================================= - Hits 16792 16791 -1 + Misses 5039 5038 -1 Partials 265 265 ``` | [Flag](https://app.codecov.io/gh/bcgov/met-public/pull/2529/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [metapi](https://app.codecov.io/gh/bcgov/met-public/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `87.88% <ø> (ø)` | | | [metweb](https://app.codecov.io/gh/bcgov/met-public/pull/2529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `64.91% <60.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/bcgov/met-public/pull/2529?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [met-api/src/met\_api/config.py](https://app.codecov.io/gh/bcgov/met-public/pull/2529?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fconfig.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9jb25maWcucHk=) | `97.33% <ø> (ø)` | | | [...web/src/components/engagement/view/SurveyBlock.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2529?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fview%2FSurveyBlock.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L3ZpZXcvU3VydmV5QmxvY2sudHN4) | `81.08% <ø> (ø)` | | | [met-web/src/components/landing/EngagementTile.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2529?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Flanding%2FEngagementTile.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9sYW5kaW5nL0VuZ2FnZW1lbnRUaWxlLnRzeA==) | `76.56% <100.00%> (ø)` | | | [met-web/src/routes/NotFound.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2529?src=pr&el=tree&filepath=met-web%2Fsrc%2Froutes%2FNotFound.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvcm91dGVzL05vdEZvdW5kLnRzeA==) | `80.00% <ø> (-1.25%)` | :arrow_down: | | [met-web/src/services/userService/index.ts](https://app.codecov.io/gh/bcgov/met-public/pull/2529?src=pr&el=tree&filepath=met-web%2Fsrc%2Fservices%2FuserService%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvc2VydmljZXMvdXNlclNlcnZpY2UvaW5kZXgudHM=) | `24.09% <100.00%> (+0.28%)` | :arrow_up: | | [...ement/view/widgets/Subscribe/FormSignUpSection.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2529?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fview%2Fwidgets%2FSubscribe%2FFormSignUpSection.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L3ZpZXcvd2lkZ2V0cy9TdWJzY3JpYmUvRm9ybVNpZ25VcFNlY3Rpb24udHN4) | `64.70% <0.00%> (ø)` | | | [...t-web/src/components/publicDashboard/Dashboard.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2529?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2FpublicDashboard%2FDashboard.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9wdWJsaWNEYXNoYm9hcmQvRGFzaGJvYXJkLnRzeA==) | `70.49% <50.00%> (ø)` | |
sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud