bcgov / met-public

Modern Engagement Tool ops
Apache License 2.0
6 stars 19 forks source link

[To Main] Feature - DESENG-627 use createBrowserRouter() in-app #2534

Closed NatSquared closed 2 months ago

NatSquared commented 2 months ago

Issue #: https://github.com/bcgov/met-public/issues/

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 72.17391% with 32 lines in your changes missing coverage. Please review.

Project coverage is 75.93%. Comparing base (ebec3bf) to head (12ab9cf).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2534 +/- ## ========================================== - Coverage 76.00% 75.93% -0.07% ========================================== Files 604 603 -1 Lines 21785 21755 -30 Branches 1663 1667 +4 ========================================== - Hits 16557 16519 -38 - Misses 4965 4973 +8 Partials 263 263 ``` | [Flag](https://app.codecov.io/gh/bcgov/met-public/pull/2534/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [metweb](https://app.codecov.io/gh/bcgov/met-public/pull/2534/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `64.45% <72.17%> (-0.17%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/bcgov/met-public/pull/2534?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [...eb/src/components/layout/Header/InternalHeader.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2534?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Flayout%2FHeader%2FInternalHeader.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9sYXlvdXQvSGVhZGVyL0ludGVybmFsSGVhZGVyLnRzeA==) | `70.21% <100.00%> (+0.64%)` | :arrow_up: | | [met-web/src/components/layout/SideNav/SideNav.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2534?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Flayout%2FSideNav%2FSideNav.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9sYXlvdXQvU2lkZU5hdi9TaWRlTmF2LnRzeA==) | `90.90% <100.00%> (+0.28%)` | :arrow_up: | | [met-web/src/components/tenantManagement/Create.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2534?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2FtenantManagement%2FCreate.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy90ZW5hbnRNYW5hZ2VtZW50L0NyZWF0ZS50c3g=) | `92.30% <100.00%> (+0.64%)` | :arrow_up: | | [...web/src/components/tenantManagement/TenantForm.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2534?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2FtenantManagement%2FTenantForm.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy90ZW5hbnRNYW5hZ2VtZW50L1RlbmFudEZvcm0udHN4) | `78.88% <100.00%> (-0.24%)` | :arrow_down: | | [met-web/src/components/tenantManagement/Edit.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2534?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2FtenantManagement%2FEdit.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy90ZW5hbnRNYW5hZ2VtZW50L0VkaXQudHN4) | `93.54% <89.47%> (+6.88%)` | :arrow_up: | | [met-web/src/components/common/Layout/index.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2534?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fcommon%2FLayout%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9jb21tb24vTGF5b3V0L2luZGV4LnRzeA==) | `66.66% <62.50%> (-15.16%)` | :arrow_down: | | [met-web/src/components/tenantManagement/Detail.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2534?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2FtenantManagement%2FDetail.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy90ZW5hbnRNYW5hZ2VtZW50L0RldGFpbC50c3g=) | `85.18% <72.72%> (+2.83%)` | :arrow_up: | | [...et-web/src/components/tenantManagement/Listing.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2534?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2FtenantManagement%2FListing.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy90ZW5hbnRNYW5hZ2VtZW50L0xpc3RpbmcudHN4) | `72.41% <60.00%> (-2.01%)` | :arrow_down: | | [...eb/src/components/common/Navigation/Breadcrumb.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2534?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fcommon%2FNavigation%2FBreadcrumb.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9jb21tb24vTmF2aWdhdGlvbi9CcmVhZGNydW1iLnRzeA==) | `35.71% <33.33%> (-64.29%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/bcgov/met-public/pull/2534/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov)
sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud