bcgov / met-public

Modern Engagement Tool ops
Apache License 2.0
6 stars 19 forks source link

[To Main] Feature - DESENG-629: Add new engagement fields #2537

Closed NatSquared closed 2 months ago

NatSquared commented 2 months ago

Issue #: 🎟️ DESENG-629

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.97%. Comparing base (34e3854) to head (4e36950). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2537 +/- ## ========================================== + Coverage 75.94% 75.97% +0.02% ========================================== Files 603 603 Lines 21758 21781 +23 Branches 1667 1671 +4 ========================================== + Hits 16525 16548 +23 Misses 4970 4970 Partials 263 263 ``` | [Flag](https://app.codecov.io/gh/bcgov/met-public/pull/2537/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [metapi](https://app.codecov.io/gh/bcgov/met-public/pull/2537/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `87.89% <100.00%> (+0.01%)` | :arrow_up: | | [metweb](https://app.codecov.io/gh/bcgov/met-public/pull/2537/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `64.52% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/bcgov/met-public/pull/2537?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [met-api/src/met\_api/models/engagement.py](https://app.codecov.io/gh/bcgov/met-public/pull/2537?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fmodels%2Fengagement.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9tb2RlbHMvZW5nYWdlbWVudC5weQ==) | `78.86% <100.00%> (+0.33%)` | :arrow_up: | | [...t-api/src/met\_api/models/engagement\_translation.py](https://app.codecov.io/gh/bcgov/met-public/pull/2537?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fmodels%2Fengagement_translation.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9tb2RlbHMvZW5nYWdlbWVudF90cmFuc2xhdGlvbi5weQ==) | `96.92% <100.00%> (+0.09%)` | :arrow_up: | | [met-api/src/met\_api/schemas/engagement.py](https://app.codecov.io/gh/bcgov/met-public/pull/2537?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fschemas%2Fengagement.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9zY2hlbWFzL2VuZ2FnZW1lbnQucHk=) | `93.33% <100.00%> (+0.35%)` | :arrow_up: | | [...-api/src/met\_api/schemas/engagement\_translation.py](https://app.codecov.io/gh/bcgov/met-public/pull/2537?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fschemas%2Fengagement_translation.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9zY2hlbWFzL2VuZ2FnZW1lbnRfdHJhbnNsYXRpb24ucHk=) | `100.00% <100.00%> (ø)` | | | [met-api/src/met\_api/services/engagement\_service.py](https://app.codecov.io/gh/bcgov/met-public/pull/2537?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fservices%2Fengagement_service.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9zZXJ2aWNlcy9lbmdhZ2VtZW50X3NlcnZpY2UucHk=) | `71.35% <ø> (ø)` | | | [...met\_api/services/engagement\_translation\_service.py](https://app.codecov.io/gh/bcgov/met-public/pull/2537?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fservices%2Fengagement_translation_service.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9zZXJ2aWNlcy9lbmdhZ2VtZW50X3RyYW5zbGF0aW9uX3NlcnZpY2UucHk=) | `88.88% <100.00%> (+0.22%)` | :arrow_up: | | [met-web/src/components/common/Input/TextInput.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2537?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fcommon%2FInput%2FTextInput.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9jb21tb24vSW5wdXQvVGV4dElucHV0LnRzeA==) | `100.00% <100.00%> (ø)` | | | [...b/src/components/engagement/form/ActionContext.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2537?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fform%2FActionContext.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2Zvcm0vQWN0aW9uQ29udGV4dC50c3g=) | `61.40% <100.00%> (+0.22%)` | :arrow_up: | | [...ntFormTabs/EngagementContent/SummaryTabContent.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2537?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fform%2FEngagementFormTabs%2FEngagementContent%2FSummaryTabContent.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2Zvcm0vRW5nYWdlbWVudEZvcm1UYWJzL0VuZ2FnZW1lbnRDb250ZW50L1N1bW1hcnlUYWJDb250ZW50LnRzeA==) | `87.50% <100.00%> (ø)` | | | [...agement/form/EngagementFormTabs/EngagementForm.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2537?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fform%2FEngagementFormTabs%2FEngagementForm.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2Zvcm0vRW5nYWdlbWVudEZvcm1UYWJzL0VuZ2FnZW1lbnRGb3JtLnRzeA==) | `88.13% <100.00%> (+1.34%)` | :arrow_up: | | ... and [3 more](https://app.codecov.io/gh/bcgov/met-public/pull/2537?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | |
sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud