bcgov / met-public

Modern Engagement Tool ops
Apache License 2.0
6 stars 19 forks source link

Feature/deseng623 Add language selector UI based roughly on ISO 639 codes #2540

Closed Baelx closed 2 months ago

Baelx commented 2 months ago

Issue #: https://github.com/bcgov/met-public/issues/

Description of changes:

Note for reviewer Most of this work has already been reviewed. This PR merges that previous work into main and introduces new code for:

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 59.01639% with 25 lines in your changes missing coverage. Please review.

Project coverage is 75.93%. Comparing base (8512584) to head (47a99b8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2540 +/- ## ========================================== - Coverage 75.98% 75.93% -0.05% ========================================== Files 603 604 +1 Lines 21800 21807 +7 Branches 1678 1689 +11 ========================================== - Hits 16564 16559 -5 - Misses 4974 4985 +11 - Partials 262 263 +1 ``` | [Flag](https://app.codecov.io/gh/bcgov/met-public/pull/2540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [metweb](https://app.codecov.io/gh/bcgov/met-public/pull/2540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `64.52% <59.01%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/bcgov/met-public/pull/2540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [met-api/src/met\_api/models/\_\_init\_\_.py](https://app.codecov.io/gh/bcgov/met-public/pull/2540?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fmodels%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9tb2RlbHMvX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | | | [met-api/src/met\_api/models/language.py](https://app.codecov.io/gh/bcgov/met-public/pull/2540?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fmodels%2Flanguage.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9tb2RlbHMvbGFuZ3VhZ2UucHk=) | `94.73% <ø> (-2.41%)` | :arrow_down: | | [met-api/src/met\_api/resources/language.py](https://app.codecov.io/gh/bcgov/met-public/pull/2540?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fresources%2Flanguage.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9yZXNvdXJjZXMvbGFuZ3VhZ2UucHk=) | `79.24% <ø> (+5.82%)` | :arrow_up: | | [met-api/src/met\_api/services/language\_service.py](https://app.codecov.io/gh/bcgov/met-public/pull/2540?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fservices%2Flanguage_service.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9zZXJ2aWNlcy9sYW5ndWFnZV9zZXJ2aWNlLnB5) | `94.44% <ø> (+7.77%)` | :arrow_up: | | [met-api/src/met\_api/utils/roles.py](https://app.codecov.io/gh/bcgov/met-public/pull/2540?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Futils%2Froles.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS91dGlscy9yb2xlcy5weQ==) | `100.00% <ø> (ø)` | | | [met-web/src/apiManager/endpoints/index.ts](https://app.codecov.io/gh/bcgov/met-public/pull/2540?src=pr&el=tree&filepath=met-web%2Fsrc%2FapiManager%2Fendpoints%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvYXBpTWFuYWdlci9lbmRwb2ludHMvaW5kZXgudHM=) | `100.00% <ø> (ø)` | | | [met-web/src/components/language/index.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2540?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Flanguage%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9sYW5ndWFnZS9pbmRleC50c3g=) | `59.01% <59.01%> (ø)` | |
sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud