bcgov / met-public

Modern Engagement Tool ops
Apache License 2.0
6 stars 19 forks source link

[To Main] DESENG-635: Fix tenant landing page #2548

Closed NatSquared closed 1 month ago

NatSquared commented 1 month ago

Issue #: 🎟️ DESENG-635

Description of changes: -Bugfix Fix tenant landing page

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 75.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 75.94%. Comparing base (dcee2a8) to head (8d5ccf0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2548 +/- ## ========================================== + Coverage 75.92% 75.94% +0.01% ========================================== Files 608 608 Lines 21998 21991 -7 Branches 1709 1709 ========================================== - Hits 16703 16700 -3 + Misses 5032 5028 -4 Partials 263 263 ``` | [Flag](https://app.codecov.io/gh/bcgov/met-public/pull/2548/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [metapi](https://app.codecov.io/gh/bcgov/met-public/pull/2548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `87.73% <100.00%> (ø)` | | | [metweb](https://app.codecov.io/gh/bcgov/met-public/pull/2548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `64.71% <69.23%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/bcgov/met-public/pull/2548?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [met-api/src/met\_api/models/tenant.py](https://app.codecov.io/gh/bcgov/met-public/pull/2548?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fmodels%2Ftenant.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9tb2RlbHMvdGVuYW50LnB5) | `100.00% <100.00%> (ø)` | | | [met-api/src/met\_api/schemas/tenant.py](https://app.codecov.io/gh/bcgov/met-public/pull/2548?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fschemas%2Ftenant.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9zY2hlbWFzL3RlbmFudC5weQ==) | `100.00% <100.00%> (ø)` | | | [...t-web/src/components/common/Typography/Headers.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2548?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fcommon%2FTypography%2FHeaders.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9jb21tb24vVHlwb2dyYXBoeS9IZWFkZXJzLnRzeA==) | `85.71% <100.00%> (+0.52%)` | :arrow_up: | | [...et-web/src/components/landing/LandingComponent.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2548?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Flanding%2FLandingComponent.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9sYW5kaW5nL0xhbmRpbmdDb21wb25lbnQudHN4) | `100.00% <100.00%> (ø)` | | | [met-web/src/components/tenantManagement/Detail.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2548?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2FtenantManagement%2FDetail.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy90ZW5hbnRNYW5hZ2VtZW50L0RldGFpbC50c3g=) | `85.18% <100.00%> (ø)` | | | [...web/src/components/tenantManagement/TenantForm.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2548?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2FtenantManagement%2FTenantForm.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy90ZW5hbnRNYW5hZ2VtZW50L1RlbmFudEZvcm0udHN4) | `78.88% <83.33%> (ø)` | | | [...eb/src/components/layout/Header/InternalHeader.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2548?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Flayout%2FHeader%2FInternalHeader.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9sYXlvdXQvSGVhZGVyL0ludGVybmFsSGVhZGVyLnRzeA==) | `73.68% <40.00%> (+3.47%)` | :arrow_up: | | [met-web/src/reduxSlices/tenantSlice.ts](https://app.codecov.io/gh/bcgov/met-public/pull/2548?src=pr&el=tree&filepath=met-web%2Fsrc%2FreduxSlices%2FtenantSlice.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvcmVkdXhTbGljZXMvdGVuYW50U2xpY2UudHM=) | `25.00% <0.00%> (ø)` | |
sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud