bcgov / met-public

Modern Engagement Tool ops
Apache License 2.0
6 stars 19 forks source link

[To Main] DESENG-643: Final changes for engagement loader optimizations #2558

Closed NatSquared closed 4 months ago

NatSquared commented 4 months ago

Issue #: 🎟️ DESENG-643

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 78.26087% with 35 lines in your changes missing coverage. Please review.

Project coverage is 75.99%. Comparing base (085451b) to head (9b199b0). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2558 +/- ## ========================================== + Coverage 75.96% 75.99% +0.03% ========================================== Files 609 609 Lines 21960 21924 -36 Branches 1711 1747 +36 ========================================== - Hits 16682 16662 -20 + Misses 5015 4998 -17 - Partials 263 264 +1 ``` | [Flag](https://app.codecov.io/gh/bcgov/met-public/pull/2558/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Ξ” | | |---|---|---| | [metapi](https://app.codecov.io/gh/bcgov/met-public/pull/2558/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `87.74% <0.00%> (ΓΈ)` | | | [metweb](https://app.codecov.io/gh/bcgov/met-public/pull/2558/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `64.75% <78.75%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/bcgov/met-public/pull/2558?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Ξ” | | |---|---|---| | [...gagementFormTabs/EngagementContent/ContentTabs.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2558?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fform%2FEngagementFormTabs%2FEngagementContent%2FContentTabs.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2Zvcm0vRW5nYWdlbWVudEZvcm1UYWJzL0VuZ2FnZW1lbnRDb250ZW50L0NvbnRlbnRUYWJzLnRzeA==) | `79.01% <100.00%> (+2.18%)` | :arrow_up: | | [...ntFormTabs/EngagementContent/SummaryTabContent.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2558?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fform%2FEngagementFormTabs%2FEngagementContent%2FSummaryTabContent.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2Zvcm0vRW5nYWdlbWVudEZvcm1UYWJzL0VuZ2FnZW1lbnRDb250ZW50L1N1bW1hcnlUYWJDb250ZW50LnRzeA==) | `87.50% <ΓΈ> (ΓΈ)` | | | [...agement/form/EngagementFormTabs/EngagementForm.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2558?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fform%2FEngagementFormTabs%2FEngagementForm.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2Zvcm0vRW5nYWdlbWVudEZvcm1UYWJzL0VuZ2FnZW1lbnRGb3JtLnRzeA==) | `88.13% <ΓΈ> (ΓΈ)` | | | [...ment/form/EngagementFormTabs/SurveyBlock/index.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2558?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fform%2FEngagementFormTabs%2FSurveyBlock%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2Zvcm0vRW5nYWdlbWVudEZvcm1UYWJzL1N1cnZleUJsb2NrL2luZGV4LnRzeA==) | `66.66% <100.00%> (+1.55%)` | :arrow_up: | | [...mponents/engagement/form/EngagementFormWrapper.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2558?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fform%2FEngagementFormWrapper.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2Zvcm0vRW5nYWdlbWVudEZvcm1XcmFwcGVyLnRzeA==) | `100.00% <100.00%> (ΓΈ)` | | | [...agement/listing/AdvancedSearch/SearchComponent.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2558?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Flisting%2FAdvancedSearch%2FSearchComponent.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2xpc3RpbmcvQWR2YW5jZWRTZWFyY2gvU2VhcmNoQ29tcG9uZW50LnRzeA==) | `86.84% <100.00%> (+3.50%)` | :arrow_up: | | [...components/engagement/view/widgets/WidgetBlock.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2558?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fview%2Fwidgets%2FWidgetBlock.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L3ZpZXcvd2lkZ2V0cy9XaWRnZXRCbG9jay50c3g=) | `100.00% <100.00%> (ΓΈ)` | | | [.../src/components/imageUpload/imageUploadContext.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2558?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2FimageUpload%2FimageUploadContext.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9pbWFnZVVwbG9hZC9pbWFnZVVwbG9hZENvbnRleHQudHN4) | `50.00% <100.00%> (+4.54%)` | :arrow_up: | | [met-web/src/services/engagementService/index.ts](https://app.codecov.io/gh/bcgov/met-public/pull/2558?src=pr&el=tree&filepath=met-web%2Fsrc%2Fservices%2FengagementService%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvc2VydmljZXMvZW5nYWdlbWVudFNlcnZpY2UvaW5kZXgudHM=) | `31.81% <ΓΈ> (ΓΈ)` | | | [...api/services/engagement\_summary\_content\_service.py](https://app.codecov.io/gh/bcgov/met-public/pull/2558?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fservices%2Fengagement_summary_content_service.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9zZXJ2aWNlcy9lbmdhZ2VtZW50X3N1bW1hcnlfY29udGVudF9zZXJ2aWNlLnB5) | `97.14% <0.00%> (ΓΈ)` | | | ... and [6 more](https://app.codecov.io/gh/bcgov/met-public/pull/2558?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/bcgov/met-public/pull/2558/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov)
sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud