search

bcgov / met-public

Modern Engagement Tool ops
Apache License 2.0
6 stars 19 forks source link

[To Main] DESENG-660: Admin Header Redesign #2569

Closed NatSquared closed 4 months ago

NatSquared commented 4 months ago

Issue #: 🎟️ DESENG-660

✅ This PR consists of changes from:

2567 (Approved)

2568 (Approved)

b6fa784 (Cosmetic changes only)

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 79.29293% with 41 lines in your changes missing coverage. Please review.

Project coverage is 76.04%. Comparing base (2cd56b4) to head (55c2c7a).

Files Patch % Lines
met-api/src/met_api/resources/staff_user.py 51.72% 14 Missing :warning:
...eb/src/components/layout/Header/InternalHeader.tsx 86.59% 13 Missing :warning:
.../src/components/common/Navigation/DropdownMenu.tsx 84.21% 5 Missing and 1 partial :warning:
met-web/src/services/tenantService/index.tsx 20.00% 3 Missing and 1 partial :warning:
met-web/src/components/layout/SideNav/SideNav.tsx 89.47% 2 Missing :warning:
...et-api/src/met_api/models/user_group_membership.py 80.00% 1 Missing :warning:
.../met_api/services/user_group_membership_service.py 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2569 +/- ## ========================================== + Coverage 76.02% 76.04% +0.01% ========================================== Files 609 609 Lines 21940 22075 +135 Branches 1752 1782 +30 ========================================== + Hits 16679 16786 +107 - Misses 4998 5025 +27 - Partials 263 264 +1 ``` | [Flag](https://app.codecov.io/gh/bcgov/met-public/pull/2569/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [metapi](https://app.codecov.io/gh/bcgov/met-public/pull/2569/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `87.64% <58.97%> (-0.11%)` | :arrow_down: | | [metweb](https://app.codecov.io/gh/bcgov/met-public/pull/2569/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `65.00% <84.27%> (+0.20%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/bcgov/met-public/pull/2569?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [met-web/src/apiManager/endpoints/index.ts](https://app.codecov.io/gh/bcgov/met-public/pull/2569?src=pr&el=tree&filepath=met-web%2Fsrc%2FapiManager%2Fendpoints%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvYXBpTWFuYWdlci9lbmRwb2ludHMvaW5kZXgudHM=) | `100.00% <ø> (ø)` | | | [met-web/src/components/common/Layout/index.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2569?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fcommon%2FLayout%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9jb21tb24vTGF5b3V0L2luZGV4LnRzeA==) | `88.88% <ø> (ø)` | | | [...et-web/src/components/engagement/listing/index.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2569?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Flisting%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2xpc3RpbmcvaW5kZXgudHN4) | `76.12% <ø> (ø)` | | | [...et-api/src/met\_api/models/user\_group\_membership.py](https://app.codecov.io/gh/bcgov/met-public/pull/2569?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fmodels%2Fuser_group_membership.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9tb2RlbHMvdXNlcl9ncm91cF9tZW1iZXJzaGlwLnB5) | `84.09% <80.00%> (-0.91%)` | :arrow_down: | | [.../met\_api/services/user\_group\_membership\_service.py](https://app.codecov.io/gh/bcgov/met-public/pull/2569?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fservices%2Fuser_group_membership_service.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9zZXJ2aWNlcy91c2VyX2dyb3VwX21lbWJlcnNoaXBfc2VydmljZS5weQ==) | `96.29% <80.00%> (-3.71%)` | :arrow_down: | | [met-web/src/components/layout/SideNav/SideNav.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2569?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Flayout%2FSideNav%2FSideNav.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9sYXlvdXQvU2lkZU5hdi9TaWRlTmF2LnRzeA==) | `94.23% <89.47%> (+0.89%)` | :arrow_up: | | [met-web/src/services/tenantService/index.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2569?src=pr&el=tree&filepath=met-web%2Fsrc%2Fservices%2FtenantService%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvc2VydmljZXMvdGVuYW50U2VydmljZS9pbmRleC50c3g=) | `25.00% <20.00%> (-0.81%)` | :arrow_down: | | [.../src/components/common/Navigation/DropdownMenu.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2569?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fcommon%2FNavigation%2FDropdownMenu.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9jb21tb24vTmF2aWdhdGlvbi9Ecm9wZG93bk1lbnUudHN4) | `84.21% <84.21%> (ø)` | | | [...eb/src/components/layout/Header/InternalHeader.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2569?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Flayout%2FHeader%2FInternalHeader.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9sYXlvdXQvSGVhZGVyL0ludGVybmFsSGVhZGVyLnRzeA==) | `87.12% <86.59%> (+13.44%)` | :arrow_up: | | [met-api/src/met\_api/resources/staff\_user.py](https://app.codecov.io/gh/bcgov/met-public/pull/2569?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fresources%2Fstaff_user.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9yZXNvdXJjZXMvc3RhZmZfdXNlci5weQ==) | `84.89% <51.72%> (-8.81%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/bcgov/met-public/pull/2569/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov)
sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud