bcgov / met-public

Modern Engagement Tool ops
Apache License 2.0
6 stars 19 forks source link

DESENG-675 Make widget component "reusable" #2579

Closed Baelx closed 3 months ago

Baelx commented 3 months ago

Issue #: https://citz-gdx.atlassian.net/browse/DESENG-675

Description of changes:

Tips for reviewers

User Guide update ticket (if applicable): N/A

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.03%. Comparing base (e2d09dd) to head (0d86c29).

Files Patch % Lines
...form/EngagementWidgets/Documents/AddFileDrawer.tsx 50.00% 1 Missing :warning:
...m/EngagementWidgets/Documents/CreateFolderForm.tsx 50.00% 1 Missing :warning:
...m/EngagementWidgets/Documents/UploadFileDrawer.tsx 50.00% 1 Missing :warning:
...gagementWidgets/Events/InPersonEventFormDrawer.tsx 50.00% 1 Missing :warning:
...agementWidgets/Events/VirtualSessionFormDrawer.tsx 50.00% 1 Missing :warning:
...nts/engagement/form/EngagementWidgets/Map/Form.tsx 50.00% 1 Missing :warning:
...ent/form/EngagementWidgets/WidgetDrawerContext.tsx 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2579 +/- ## ========================================== - Coverage 76.04% 76.03% -0.01% ========================================== Files 609 609 Lines 22083 22105 +22 Branches 1785 1797 +12 ========================================== + Hits 16793 16808 +15 - Misses 5026 5033 +7 Partials 264 264 ``` | [Flag](https://app.codecov.io/gh/bcgov/met-public/pull/2579/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [metweb](https://app.codecov.io/gh/bcgov/met-public/pull/2579/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `65.03% <73.07%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/bcgov/met-public/pull/2579?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [met-api/src/met\_api/models/widget.py](https://app.codecov.io/gh/bcgov/met-public/pull/2579?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fmodels%2Fwidget.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9tb2RlbHMvd2lkZ2V0LnB5) | `91.07% <ø> (ø)` | | | [met-api/src/met\_api/schemas/widget.py](https://app.codecov.io/gh/bcgov/met-public/pull/2579?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fschemas%2Fwidget.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9zY2hlbWFzL3dpZGdldC5weQ==) | `100.00% <ø> (ø)` | | | [...ts/engagement/form/EngagementWidgets/Poll/Form.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2579?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fform%2FEngagementWidgets%2FPoll%2FForm.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2Zvcm0vRW5nYWdlbWVudFdpZGdldHMvUG9sbC9Gb3JtLnRzeA==) | `81.13% <100.00%> (+0.36%)` | :arrow_up: | | [...ngagement/form/EngagementWidgets/Timeline/Form.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2579?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fform%2FEngagementWidgets%2FTimeline%2FForm.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2Zvcm0vRW5nYWdlbWVudFdpZGdldHMvVGltZWxpbmUvRm9ybS50c3g=) | `70.71% <100.00%> (+0.42%)` | :arrow_up: | | [...s/engagement/form/EngagementWidgets/Video/Form.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2579?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fform%2FEngagementWidgets%2FVideo%2FForm.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2Zvcm0vRW5nYWdlbWVudFdpZGdldHMvVmlkZW8vRm9ybS50c3g=) | `75.38% <100.00%> (+0.78%)` | :arrow_up: | | [...ementWidgets/WhoIsListening/WhoIsListeningForm.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2579?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fform%2FEngagementWidgets%2FWhoIsListening%2FWhoIsListeningForm.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2Zvcm0vRW5nYWdlbWVudFdpZGdldHMvV2hvSXNMaXN0ZW5pbmcvV2hvSXNMaXN0ZW5pbmdGb3JtLnRzeA==) | `62.50% <ø> (ø)` | | | [...idgets/WhoIsListening/WhoIsListeningOptionCard.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2579?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fform%2FEngagementWidgets%2FWhoIsListening%2FWhoIsListeningOptionCard.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2Zvcm0vRW5nYWdlbWVudFdpZGdldHMvV2hvSXNMaXN0ZW5pbmcvV2hvSXNMaXN0ZW5pbmdPcHRpb25DYXJkLnRzeA==) | `89.74% <100.00%> (+0.26%)` | :arrow_up: | | [...gement/form/EngagementWidgets/WidgetCardSwitch.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2579?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fform%2FEngagementWidgets%2FWidgetCardSwitch.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2Zvcm0vRW5nYWdlbWVudFdpZGdldHMvV2lkZ2V0Q2FyZFN3aXRjaC50c3g=) | `18.36% <100.00%> (ø)` | | | [met-web/src/models/widget.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2579?src=pr&el=tree&filepath=met-web%2Fsrc%2Fmodels%2Fwidget.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvbW9kZWxzL3dpZGdldC50c3g=) | `100.00% <100.00%> (ø)` | | | [...c/services/widgetService/DocumentService/index.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2579?src=pr&el=tree&filepath=met-web%2Fsrc%2Fservices%2FwidgetService%2FDocumentService%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvc2VydmljZXMvd2lkZ2V0U2VydmljZS9Eb2N1bWVudFNlcnZpY2UvaW5kZXgudHN4) | `19.04% <ø> (ø)` | | | ... and [12 more](https://app.codecov.io/gh/bcgov/met-public/pull/2579?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | |
sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Baelx commented 3 months ago

API tests have been failing for a while. I created a ticket to look into it: https://citz-gdx.atlassian.net/browse/DESENG-699

Will be going ahead with merging