bcgov / met-public

Modern Engagement Tool ops
Apache License 2.0
6 stars 19 forks source link

DESENG-689: Add image widget #2586

Closed NatSquared closed 2 months ago

NatSquared commented 2 months ago

Issue #: 🎟️ DESENG-689

Description of changes:

User Guide update ticket (if applicable): https://citz-gdx.atlassian.net/browse/DESENG-705

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 60.16949% with 47 lines in your changes missing coverage. Please review.

Project coverage is 75.80%. Comparing base (9e5a4f8) to head (ae7b6b9).

Files with missing lines Patch % Lines
...t-api/src/met_api/services/widget_image_service.py 36.11% 23 Missing :warning:
met-api/src/met_api/resources/widget_image.py 63.26% 18 Missing :warning:
met-api/src/met_api/models/widget_image.py 72.72% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2586 +/- ## ========================================== + Coverage 75.74% 75.80% +0.05% ========================================== Files 603 607 +4 Lines 21811 21881 +70 Branches 1811 1810 -1 ========================================== + Hits 16521 16587 +66 - Misses 5028 5032 +4 Partials 262 262 ``` | [Flag](https://app.codecov.io/gh/bcgov/met-public/pull/2586/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [metapi](https://app.codecov.io/gh/bcgov/met-public/pull/2586/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `87.14% <60.16%> (-0.31%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/bcgov/met-public/pull/2586?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [met-api/src/met\_api/constants/widget.py](https://app.codecov.io/gh/bcgov/met-public/pull/2586?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fconstants%2Fwidget.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9jb25zdGFudHMvd2lkZ2V0LnB5) | `100.00% <100.00%> (ø)` | | | [met-api/src/met\_api/models/\_\_init\_\_.py](https://app.codecov.io/gh/bcgov/met-public/pull/2586?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fmodels%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9tb2RlbHMvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [met-api/src/met\_api/resources/\_\_init\_\_.py](https://app.codecov.io/gh/bcgov/met-public/pull/2586?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fresources%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9yZXNvdXJjZXMvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [met-api/src/met\_api/schemas/widget\_image.py](https://app.codecov.io/gh/bcgov/met-public/pull/2586?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fschemas%2Fwidget_image.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9zY2hlbWFzL3dpZGdldF9pbWFnZS5weQ==) | `100.00% <100.00%> (ø)` | | | [met-web/src/apiManager/endpoints/index.ts](https://app.codecov.io/gh/bcgov/met-public/pull/2586?src=pr&el=tree&filepath=met-web%2Fsrc%2FapiManager%2Fendpoints%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvYXBpTWFuYWdlci9lbmRwb2ludHMvaW5kZXgudHM=) | `100.00% <ø> (ø)` | | | [met-web/src/apiManager/httpRequestHandler/index.ts](https://app.codecov.io/gh/bcgov/met-public/pull/2586?src=pr&el=tree&filepath=met-web%2Fsrc%2FapiManager%2FhttpRequestHandler%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvYXBpTWFuYWdlci9odHRwUmVxdWVzdEhhbmRsZXIvaW5kZXgudHM=) | `47.61% <ø> (-2.39%)` | :arrow_down: | | [met-web/src/components/common/Input/TextInput.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2586?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fcommon%2FInput%2FTextInput.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9jb21tb24vSW5wdXQvVGV4dElucHV0LnRzeA==) | `100.00% <ø> (ø)` | | | [.../components/engagement/admin/view/AuthoringTab.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2586?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fadmin%2Fview%2FAuthoringTab.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2FkbWluL3ZpZXcvQXV0aG9yaW5nVGFiLnRzeA==) | `25.92% <ø> (-1.35%)` | :arrow_down: | | [...gement/form/EngagementWidgets/WidgetCardSwitch.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2586?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fform%2FEngagementWidgets%2FWidgetCardSwitch.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2Zvcm0vRW5nYWdlbWVudFdpZGdldHMvV2lkZ2V0Q2FyZFN3aXRjaC50c3g=) | `100.00% <ø> (+81.63%)` | :arrow_up: | | [...gement/form/EngagementWidgets/WidgetDrawerTabs.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2586?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fform%2FEngagementWidgets%2FWidgetDrawerTabs.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2Zvcm0vRW5nYWdlbWVudFdpZGdldHMvV2lkZ2V0RHJhd2VyVGFicy50c3g=) | `100.00% <ø> (ø)` | | | ... and [9 more](https://app.codecov.io/gh/bcgov/met-public/pull/2586?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | |
Baelx commented 2 months ago

Should we create a ticket for documentation in the user guide? Anything holding us back from that?

NatSquared commented 2 months ago

Should we create a ticket for documentation in the user guide? Anything holding us back from that?

Created a ticket - https://citz-gdx.atlassian.net/browse/DESENG-705

NatSquared commented 2 months ago

Before proceeding, could you please just let me know:

  • If all form labels are properly associated with controls

✅ All form controls now have labels associated where possible.

  • If the uploaded image gets deleted when a widget is deleted. We'll need to make sure we're doing that

☑️ Ticket created to follow up with deleting images from widgets, engagements, etc

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud