bcgov / met-public

Modern Engagement Tool ops
Apache License 2.0
6 stars 19 forks source link

Feature/deseng692: Reverted to previous title logic for video widget #2595

Closed jareth-whitney closed 1 month ago

jareth-whitney commented 1 month ago

Issue #: https://citz-gdx.atlassian.net/browse/DESENG-692

Description of changes:

User Guide update ticket (if applicable): N/A

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.10%. Comparing base (e594f0d) to head (12f4f29).

Files with missing lines Patch % Lines
...agement/old-view/widgets/Video/VideoWidgetView.tsx 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2595 +/- ## ======================================= Coverage 75.10% 75.10% ======================================= Files 612 612 Lines 22254 22247 -7 Branches 1870 1869 -1 ======================================= - Hits 16714 16709 -5 + Misses 5267 5265 -2 Partials 273 273 ``` | [Flag](https://app.codecov.io/gh/bcgov/met-public/pull/2595/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [metapi](https://app.codecov.io/gh/bcgov/met-public/pull/2595/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `87.13% <100.00%> (+<0.01%)` | :arrow_up: | | [metweb](https://app.codecov.io/gh/bcgov/met-public/pull/2595/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `64.11% <33.33%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/bcgov/met-public/pull/2595?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [met-api/src/met\_api/models/widget\_translation.py](https://app.codecov.io/gh/bcgov/met-public/pull/2595?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fmodels%2Fwidget_translation.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9tb2RlbHMvd2lkZ2V0X3RyYW5zbGF0aW9uLnB5) | `98.00% <ø> (-0.04%)` | :arrow_down: | | [met-api/src/met\_api/models/widget\_video.py](https://app.codecov.io/gh/bcgov/met-public/pull/2595?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fmodels%2Fwidget_video.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9tb2RlbHMvd2lkZ2V0X3ZpZGVvLnB5) | `100.00% <ø> (ø)` | | | [met-api/src/met\_api/schemas/widget\_translation.py](https://app.codecov.io/gh/bcgov/met-public/pull/2595?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fschemas%2Fwidget_translation.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9zY2hlbWFzL3dpZGdldF90cmFuc2xhdGlvbi5weQ==) | `100.00% <ø> (ø)` | | | [met-api/src/met\_api/schemas/widget\_video.py](https://app.codecov.io/gh/bcgov/met-public/pull/2595?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fschemas%2Fwidget_video.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9zY2hlbWFzL3dpZGdldF92aWRlby5weQ==) | `100.00% <100.00%> (ø)` | | | [...src/met\_api/services/widget\_translation\_service.py](https://app.codecov.io/gh/bcgov/met-public/pull/2595?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fservices%2Fwidget_translation_service.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9zZXJ2aWNlcy93aWRnZXRfdHJhbnNsYXRpb25fc2VydmljZS5weQ==) | `76.47% <ø> (+0.88%)` | :arrow_up: | | [...t-api/src/met\_api/services/widget\_video\_service.py](https://app.codecov.io/gh/bcgov/met-public/pull/2595?src=pr&el=tree&filepath=met-api%2Fsrc%2Fmet_api%2Fservices%2Fwidget_video_service.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LWFwaS9zcmMvbWV0X2FwaS9zZXJ2aWNlcy93aWRnZXRfdmlkZW9fc2VydmljZS5weQ==) | `94.28% <ø> (-0.16%)` | :arrow_down: | | [...s/engagement/form/EngagementWidgets/Video/Form.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2595?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fform%2FEngagementWidgets%2FVideo%2FForm.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L2Zvcm0vRW5nYWdlbWVudFdpZGdldHMvVmlkZW8vRm9ybS50c3g=) | `75.75% <100.00%> (+0.75%)` | :arrow_up: | | [.../src/services/widgetService/VideoService/index.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2595?src=pr&el=tree&filepath=met-web%2Fsrc%2Fservices%2FwidgetService%2FVideoService%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvc2VydmljZXMvd2lkZ2V0U2VydmljZS9WaWRlb1NlcnZpY2UvaW5kZXgudHN4) | `27.27% <ø> (ø)` | | | [...agement/old-view/widgets/Video/VideoWidgetView.tsx](https://app.codecov.io/gh/bcgov/met-public/pull/2595?src=pr&el=tree&filepath=met-web%2Fsrc%2Fcomponents%2Fengagement%2Fold-view%2Fwidgets%2FVideo%2FVideoWidgetView.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-bWV0LXdlYi9zcmMvY29tcG9uZW50cy9lbmdhZ2VtZW50L29sZC12aWV3L3dpZGdldHMvVmlkZW8vVmlkZW9XaWRnZXRWaWV3LnRzeA==) | `19.04% <0.00%> (ø)` | |