bcgov / name-examination

Service BC Name Examination System
4 stars 36 forks source link

Investigate Effort for a Few UI Changes #995

Closed LJTrent closed 6 years ago

LJTrent commented 6 years ago

Task (Use for Work not Directly related to a Story but supports the Sprint Goals)

Detailed Description

There are a few things that the examiners could benefit from that require a technical review to determine the scope and effort of the ask. For these items please consult with John and Julia to determine details but in a nutshell please investigate the following items:

1) Increasing the overall font size. Personally I need to bump it up to about 110% to be readable. 2) Add Hot keys to all buttons. 3) Change tab order so that from manual search you tab to the first item in the conflict list if there are conflicts. 4) Reduce the size of the submission info box that is displayed.

Sprint Goal
Acceptance Criteria

Technical tickets with an evaluation of the work required, design, any refactoring and new tests required.

Definition of Done (:one:-Mandatory to add to the Backlog, :two:-Mandatory to add to the Sprint Backlog)
katiemcgoff commented 6 years ago

Upon discussion (Kaine, John, Susan, Katie):

  1. font size - can be done. LOE 1/2 day. #1000

1a) Related changes (will log separately) re. examination boxes (conflict/history):

  1. hot keys - can implement for all keys, will start the work but wait on exact keys requested from John/Kaine #1001

  2. tab order - yes, very quick change but implications to other tab orders. Will get done asap so can be reviewed next week (week of Oct 15) #1005

  3. decrease NR header - wait on mockup from John; we discussed nwpta chg and maybe priority chg. #1002

@LJTrent What did you have in mind for front-end tests? I think we are about to have Jest tests running, is that what you meant?

LJTrent commented 6 years ago

@katiemcgoff Front-end test for now shoudl include I believe JEST and may include any unit testing we agree upon. We will need @ericminio input regarding front-end unit testing.

ericminio commented 6 years ago

In case it is useful, I shared in a PR one way to secure a feature before refactoring. Please explore PR https://github.com/bcgov/name-examination/pull/1007

katiemcgoff commented 6 years ago

Investigation done, all UI improvements implemented and moving through pipelines.