bcgov / namerequest

Public Front End for the Name Request System
1 stars 44 forks source link

Ported in date and cancel changes from master branch #348

Closed severinbeauvais closed 3 years ago

severinbeauvais commented 3 years ago

Issue #: /bcgov/entity#6812 and /bcgov/entity#6507

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

severinbeauvais commented 3 years ago

Should we be concerned we have payment related requests outside the payment module? Or, is long term plan to port that whole module over in the main store perhaps?

Do you mean the code in actions.ts ? As you've commented in several places, some of these functions are not actions. As such, I'd love to see them better organized.

I see more complexity here in having multiple modules instead of just one. So, yes, I'm favour of coalescing these into a single store module. But non-actions should still be outside the store IMHO.