Advanced Search UX Updates

bcgov / namerequest

Public Front End for the Name Request System

1 stars 42 forks source link

Advanced Search UX Updates #385

Closed cameron-eyds closed 3 years ago

cameron-eyds commented 3 years ago

Issue #: /bcgov/entity#7326

Description of changes:

Updated styling and spacing.
Customized scroll bar for v-data-table.
Validation tweaks.
Enforce Date ranges. ie Start Date MUST come before End Date.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

severinbeauvais commented 3 years ago

Is this feature ready to be enabled permanently -- can the FF be deleted?

cameron-eyds commented 3 years ago

Is this feature ready to be enabled permanently -- can the FF be deleted?

Yea! Actually i think so. Do we want to remove it now, or leave it in the event there is any issues with the queries in prod?

severinbeauvais commented 3 years ago

Is this feature ready to be enabled permanently -- can the FF be deleted?

Yea! Actually i think so. Do we want to remove it now, or leave it in the event there is any issues with the queries in prod?

Your code is so nicely written... let's leave it in :)

(I'm serious about the first part.)

For the second part, sure I guess. Or ask PO.

cameron-eyds commented 3 years ago

Is this feature ready to be enabled permanently -- can the FF be deleted?

Yea! Actually i think so. Do we want to remove it now, or leave it in the event there is any issues with the queries in prod?

Your code is so nicely written... let's leave it in :)

(I'm serious about the first part.)

For the second part, sure I guess. Or ask PO.

Thanks 😁

My only concern is the query doesn't perform the same in PROD as it does in our other environments. It wouldn't be the first time we've seen surprises in Prod 😆

We can always remove it after, fairly easily.