Cleaned up enums/types before further development

bcgov / namerequest

Public Front End for the Name Request System

1 stars 44 forks source link

Cleaned up enums/types before further development #412

Closed severinbeauvais closed 3 years ago

severinbeauvais commented 3 years ago

Issue #: /bcgov/entity#7116

Description of changes:

This is cleanup before the actual implementation of the subject ticket.

updated use of enums/types
fixed some invalid type usage
added some return types
fixed some "overwrite base property" getter issues
updated app version

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

severinbeauvais commented 3 years ago

Another thing I think we should invest in is increasing the test coverage for namerequest. It scares me when the tests don't break when we do changes!

Agreed. There's lots of work to be done there. (Most tests are disabled atm due to being so out of date.) We should bring it up at grooming some time and see whether the business has an appetite for us to work on them.