bcgov / namerequest

Public Front End for the Name Request System
1 stars 42 forks source link

7811 Staff payment for Upgrade and Renew, etc #419

Closed severinbeauvais closed 3 years ago

severinbeauvais commented 3 years ago

DO NOT MERGE until the current release is deployed (in case any hotfixes are required)

Issue #: /bcgov/entity#7811, /bcgov/entity#7828, /bcgov/entity#8098 and /bcgov/entity#8153

Description of changes: Commit 1:

Commit 2:

Commit 3:

Commit 4:

Commit 5:

Commit 6:

Commit 7:

Commit 8:

Commit 9:

Commit 10:

Commit 11:

Commit 12:

Commit 13:

Commit 14:

Commit 15:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

severinbeauvais commented 3 years ago

@cameron-freshworks @eve-git @andrepestana-aot Would you guys like me to merge all these commits into a single one for review, or do you prefer me to leave it as separate commits so you can correlate what I said I did with the code changes?

severinbeauvais commented 3 years ago

@kialj876 FYI!

It doesn't look like there's much overlap between your PR and mine, so I have no preference which gets merged first.

kialj876 commented 3 years ago

@kialj876 FYI!

It doesn't look like there's much overlap between your PR and mine, so I have no preference which gets merged first.

Yeah I think you're right. I would prefer to do mine just in case and I'm not supposed to be spending any time on it anymore haha