search

bcgov / namerequest

Public Front End for the Name Request System
1 stars 42 forks source link

7960 search combo #420

Closed kialj876 closed 3 years ago

kialj876 commented 3 years ago

Issue #: /bcgov/entity#7960

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

cameron-eyds commented 3 years ago

Is quick search still a thing? I see a lot of calls to getQuickSearch() but there is configuration missing locally to run that. Just curious if we should set that config to test locally as well?

kialj876 commented 3 years ago

Is quick search still a thing? I see a lot of calls to getQuickSearch() but there is configuration missing locally to run that. Just curious if we should set that config to test locally as well?

It is yeah, but it is within the combo search so you just need the id/secret in set your config

severinbeauvais commented 3 years ago

Q: Would it make sense to add a FF to bypass some of this for any reason?

~Not needed?~ Update: see comment below

kialj876 commented 3 years ago

Q: Would it make sense to add a FF to bypass some of this for any reason?

Not needed?

No I don't think so. The worst case for things erring everywhere or partially on the backend is covered in the UI and the auto analyze distinctive/descriptive call is covered by an LD flag (this is the only call that could potentially take more than a couple seconds). Even if it took too long the design / code handles it so I don't see it being turned off unless it was +30 seconds for everyone (in dev its about 2 or 3 seconds usually). There is also a config var on the backend that will cause it to skip if needed

kialj876 commented 3 years ago

fyi I am planning to merge this after the release tomorrow (just in case they need to put any hot fixes through)