search

bcgov / namerequest

Public Front End for the Name Request System
1 stars 42 forks source link

8609 - Update node version #447

Closed andrepestana-aot closed 3 years ago

andrepestana-aot commented 3 years ago

Issue #: /bcgov/entity#8609

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

severinbeauvais commented 3 years ago

Is this the recommended solution? Is there a reason why not go to version "16.6.2" ?

andrepestana-aot commented 3 years ago

Is this the recommended solution? Is there a reason why not go to version "16.6.2" ?

@thorwolpert suggested just updating the patch version to the one that solves the vulnerability and I did it. Changing the major version will be more risky now I think.

severinbeauvais commented 3 years ago

@thorwolpert suggested just updating the patch version to the one that solves the vulnerability and I did it. Changing the major version will be more risky now I think.

Agreed. Please create a ticket to update the major version at a later date (when it isn't high priority).