bcgov / namerequest

Public Front End for the Name Request System
1 stars 42 forks source link

More mobile forms and Dialogs #462

Closed cameron-eyds closed 2 years ago

cameron-eyds commented 2 years ago

Issue #: /bcgov/entity#8667

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

severinbeauvais commented 2 years ago

You deserve to bump up the app version to 3.0.0!

severinbeauvais commented 2 years ago

Did you check Vuetify's helper classes for different media sizes? Might save you from declaring your own media queries.

cameron-eyds commented 2 years ago

It is a getter! This was done in a previous commit, this is just a small piece of the pie. To your second point, i could update to use the $vuetify.breakpoint.thresholds.xs which is the same as saying < 600 which i've done. Either or for sure!

To the third point, the app will be bumped 100%, 3.0.0 sounds good. will do this before merging back to main :)