bcgov / namerequest

Public Front End for the Name Request System
1 stars 42 forks source link

Common Component Version Update #500

Closed cameron-eyds closed 2 years ago

cameron-eyds commented 2 years ago

Issue #: /bcgov/entity#10922

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

severinbeauvais commented 2 years ago

Need to fix build error before merging.

cameron-eyds commented 2 years ago

Basic testing is OK with all these updates?

I'll need to run this one, to look into the build error But yea, unit tests ran without issue!

cameron-eyds commented 2 years ago

Need to fix build error before merging.

Took me a min to find, but the external package requires our apps webpack config to include sass-loader if it's specifying rules on the modules.