search

bcgov / namerequest

Public Front End for the Name Request System
1 stars 44 forks source link

Added try catch block prevent type error happen. #520

Closed pwei1018 closed 2 years ago

pwei1018 commented 2 years ago

Issue #: /bcgov/entity/11984

Description of changes: In some broswer, the get hotjar user function return type error. Added a try catch block to ignore the error throw up.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

pwei1018 commented 2 years ago

Isn't Omid working on this already?

Don't think so.

Definitely update the app version in package.json (and run npm i) so that we can track versions through Dev/Test/Prod environments.

It is part to 3.0.13 task. Do we still need to update the version?

https://github.com/bcgov/namerequest/commit/c8181241d9eb39cb3b7ba637df134d7f77bd65e0

severinbeauvais commented 2 years ago

It is part to 3.0.13 task. Do we still need to update the version?

Yes, otherwise how will you know the difference between the broken 3.0.13 and this new code (eg, in Dev)?

pwei1018 commented 2 years ago

It is part to 3.0.13 task. Do we still need to update the version?

Yes, otherwise how will you know the difference between the broken 3.0.13 and this new code (eg, in Dev)?

Done.