search

bcgov / namerequest

Public Front End for the Name Request System
1 stars 44 forks source link

15183 Imported Genesys Web Chat #585

Closed JazzarKarim closed 1 year ago

JazzarKarim commented 1 year ago

Issue #: /bcgov/entity#15183

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

JazzarKarim commented 1 year ago

I think this is OK... but remember to update the app version.

I did update it! From 3.3.8 to 3.3.9. Or do you mean something else?

JazzarKarim commented 1 year ago

You're also missing the new component import :)

Which component are you talking about Sev? 😟

severinbeauvais commented 1 year ago

I did update it! From 3.3.8 to 3.3.9. Or do you mean something else?

Which component are you talking about Sev? 😟

Oh, I see... First, I missed the package files. Second, you cheated and didn't run npm i, so the shared component wasn't installed (as seen in the check errors above). You should always run npm i and never update the package lock manually.

JazzarKarim commented 1 year ago

I did update it! From 3.3.8 to 3.3.9. Or do you mean something else?

Which component are you talking about Sev? 😟

Oh, I see... First, I missed the package files. Second, you cheated and didn't run npm i, so the shared component wasn't installed (as seen in the check errors above). You should always run npm i and never update the package lock manually.

I did that actually at first but I reverted the change. I looked at previous commits and I thought that this is how you update (Namerequest UI) after doing something since that's what everybody was doing. So sorry about that. Good to know.