search

bcgov / namerequest

Public Front End for the Name Request System
1 stars 44 forks source link

15183 Added content security policy to genesys web chat #586

Closed JazzarKarim closed 1 year ago

JazzarKarim commented 1 year ago

Issue #: /bcgov/entity#15183

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

seeker25 commented 1 year ago

I don't think the package and package.lock make sense to update here.

severinbeauvais commented 1 year ago

I don't think the package and package.lock make sense to update here.

If not then how would we know whether Dev or Test or Prod have the needed configuration, other than testing if the new webchat works?

seeker25 commented 1 year ago

By watching the hash on the image, they should always be checked before deploying.

Package.json is for the web app, you're making a nginx configuration change (infrastructure related).. they're two different concerns.

severinbeauvais commented 1 year ago

Package.json is for the web app, you're making a nginx configuration change (infrastructure related).. they're two different concerns.

They are different things but the webserver config and the app that is served are bundled together.

The app version is just easy to see, in any environment, from which we can deduce whether some features/commits are present or not.

Don't read my intentions in this -- I'm OK with the app version not being updated this time :)